Преглед изворни кода

drm: Reject fbs w/o format info in drm_framebuffer_init()

Any framebuffer that doesn't have proper format information when
drm_framebuffer_init() is called is a bug. Let's warn and return
an error to avoid oopsing the kernel later due to dereferencing the
NULL fb->format pointer.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1479498793-31021-23-git-send-email-ville.syrjala@linux.intel.com
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Ville Syrjälä пре 8 година
родитељ
комит
570cec3244
1 измењених фајлова са 1 додато и 1 уклоњено
  1. 1 1
      drivers/gpu/drm/drm_framebuffer.c

+ 1 - 1
drivers/gpu/drm/drm_framebuffer.c

@@ -631,7 +631,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb,
 {
 {
 	int ret;
 	int ret;
 
 
-	if (WARN_ON_ONCE(fb->dev != dev))
+	if (WARN_ON_ONCE(fb->dev != dev || !fb->format))
 		return -EINVAL;
 		return -EINVAL;
 
 
 	INIT_LIST_HEAD(&fb->filp_head);
 	INIT_LIST_HEAD(&fb->filp_head);