浏览代码

clk: qoriq: fix memory leak

If get_pll_div() fails we exited by returning NULL but we missed
releasing hwc.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Fixes: 0dfc86b3173f ("clk: qoriq: Move chip-specific knowledge into driver")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Sudip Mukherjee 9 年之前
父节点
当前提交
279104e3ad
共有 1 个文件被更改,包括 3 次插入1 次删除
  1. 3 1
      drivers/clk/clk-qoriq.c

+ 3 - 1
drivers/clk/clk-qoriq.c

@@ -778,8 +778,10 @@ static struct clk * __init create_one_cmux(struct clockgen *cg, int idx)
 	 */
 	 */
 	clksel = (cg_in(cg, hwc->reg) & CLKSEL_MASK) >> CLKSEL_SHIFT;
 	clksel = (cg_in(cg, hwc->reg) & CLKSEL_MASK) >> CLKSEL_SHIFT;
 	div = get_pll_div(cg, hwc, clksel);
 	div = get_pll_div(cg, hwc, clksel);
-	if (!div)
+	if (!div) {
+		kfree(hwc);
 		return NULL;
 		return NULL;
+	}
 
 
 	pct80_rate = clk_get_rate(div->clk);
 	pct80_rate = clk_get_rate(div->clk);
 	pct80_rate *= 8;
 	pct80_rate *= 8;