devmap.c 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414
  1. /* Copyright (c) 2017 Covalent IO, Inc. http://covalent.io
  2. *
  3. * This program is free software; you can redistribute it and/or
  4. * modify it under the terms of version 2 of the GNU General Public
  5. * License as published by the Free Software Foundation.
  6. *
  7. * This program is distributed in the hope that it will be useful, but
  8. * WITHOUT ANY WARRANTY; without even the implied warranty of
  9. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  10. * General Public License for more details.
  11. */
  12. /* Devmaps primary use is as a backend map for XDP BPF helper call
  13. * bpf_redirect_map(). Because XDP is mostly concerned with performance we
  14. * spent some effort to ensure the datapath with redirect maps does not use
  15. * any locking. This is a quick note on the details.
  16. *
  17. * We have three possible paths to get into the devmap control plane bpf
  18. * syscalls, bpf programs, and driver side xmit/flush operations. A bpf syscall
  19. * will invoke an update, delete, or lookup operation. To ensure updates and
  20. * deletes appear atomic from the datapath side xchg() is used to modify the
  21. * netdev_map array. Then because the datapath does a lookup into the netdev_map
  22. * array (read-only) from an RCU critical section we use call_rcu() to wait for
  23. * an rcu grace period before free'ing the old data structures. This ensures the
  24. * datapath always has a valid copy. However, the datapath does a "flush"
  25. * operation that pushes any pending packets in the driver outside the RCU
  26. * critical section. Each bpf_dtab_netdev tracks these pending operations using
  27. * an atomic per-cpu bitmap. The bpf_dtab_netdev object will not be destroyed
  28. * until all bits are cleared indicating outstanding flush operations have
  29. * completed.
  30. *
  31. * BPF syscalls may race with BPF program calls on any of the update, delete
  32. * or lookup operations. As noted above the xchg() operation also keep the
  33. * netdev_map consistent in this case. From the devmap side BPF programs
  34. * calling into these operations are the same as multiple user space threads
  35. * making system calls.
  36. *
  37. * Finally, any of the above may race with a netdev_unregister notifier. The
  38. * unregister notifier must search for net devices in the map structure that
  39. * contain a reference to the net device and remove them. This is a two step
  40. * process (a) dereference the bpf_dtab_netdev object in netdev_map and (b)
  41. * check to see if the ifindex is the same as the net_device being removed.
  42. * When removing the dev a cmpxchg() is used to ensure the correct dev is
  43. * removed, in the case of a concurrent update or delete operation it is
  44. * possible that the initially referenced dev is no longer in the map. As the
  45. * notifier hook walks the map we know that new dev references can not be
  46. * added by the user because core infrastructure ensures dev_get_by_index()
  47. * calls will fail at this point.
  48. */
  49. #include <linux/bpf.h>
  50. #include <linux/filter.h>
  51. #define DEV_CREATE_FLAG_MASK \
  52. (BPF_F_NUMA_NODE | BPF_F_RDONLY | BPF_F_WRONLY)
  53. struct bpf_dtab_netdev {
  54. struct net_device *dev;
  55. struct bpf_dtab *dtab;
  56. unsigned int bit;
  57. struct rcu_head rcu;
  58. };
  59. struct bpf_dtab {
  60. struct bpf_map map;
  61. struct bpf_dtab_netdev **netdev_map;
  62. unsigned long __percpu *flush_needed;
  63. struct list_head list;
  64. };
  65. static DEFINE_SPINLOCK(dev_map_lock);
  66. static LIST_HEAD(dev_map_list);
  67. static u64 dev_map_bitmap_size(const union bpf_attr *attr)
  68. {
  69. return BITS_TO_LONGS(attr->max_entries) * sizeof(unsigned long);
  70. }
  71. static struct bpf_map *dev_map_alloc(union bpf_attr *attr)
  72. {
  73. struct bpf_dtab *dtab;
  74. int err = -EINVAL;
  75. u64 cost;
  76. /* check sanity of attributes */
  77. if (attr->max_entries == 0 || attr->key_size != 4 ||
  78. attr->value_size != 4 || attr->map_flags & ~DEV_CREATE_FLAG_MASK)
  79. return ERR_PTR(-EINVAL);
  80. dtab = kzalloc(sizeof(*dtab), GFP_USER);
  81. if (!dtab)
  82. return ERR_PTR(-ENOMEM);
  83. /* mandatory map attributes */
  84. dtab->map.map_type = attr->map_type;
  85. dtab->map.key_size = attr->key_size;
  86. dtab->map.value_size = attr->value_size;
  87. dtab->map.max_entries = attr->max_entries;
  88. dtab->map.map_flags = attr->map_flags;
  89. dtab->map.numa_node = bpf_map_attr_numa_node(attr);
  90. /* make sure page count doesn't overflow */
  91. cost = (u64) dtab->map.max_entries * sizeof(struct bpf_dtab_netdev *);
  92. cost += dev_map_bitmap_size(attr) * num_possible_cpus();
  93. if (cost >= U32_MAX - PAGE_SIZE)
  94. goto free_dtab;
  95. dtab->map.pages = round_up(cost, PAGE_SIZE) >> PAGE_SHIFT;
  96. /* if map size is larger than memlock limit, reject it early */
  97. err = bpf_map_precharge_memlock(dtab->map.pages);
  98. if (err)
  99. goto free_dtab;
  100. err = -ENOMEM;
  101. /* A per cpu bitfield with a bit per possible net device */
  102. dtab->flush_needed = __alloc_percpu(dev_map_bitmap_size(attr),
  103. __alignof__(unsigned long));
  104. if (!dtab->flush_needed)
  105. goto free_dtab;
  106. dtab->netdev_map = bpf_map_area_alloc(dtab->map.max_entries *
  107. sizeof(struct bpf_dtab_netdev *),
  108. dtab->map.numa_node);
  109. if (!dtab->netdev_map)
  110. goto free_dtab;
  111. spin_lock(&dev_map_lock);
  112. list_add_tail_rcu(&dtab->list, &dev_map_list);
  113. spin_unlock(&dev_map_lock);
  114. return &dtab->map;
  115. free_dtab:
  116. free_percpu(dtab->flush_needed);
  117. kfree(dtab);
  118. return ERR_PTR(err);
  119. }
  120. static void dev_map_free(struct bpf_map *map)
  121. {
  122. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  123. int i, cpu;
  124. /* At this point bpf_prog->aux->refcnt == 0 and this map->refcnt == 0,
  125. * so the programs (can be more than one that used this map) were
  126. * disconnected from events. Wait for outstanding critical sections in
  127. * these programs to complete. The rcu critical section only guarantees
  128. * no further reads against netdev_map. It does __not__ ensure pending
  129. * flush operations (if any) are complete.
  130. */
  131. spin_lock(&dev_map_lock);
  132. list_del_rcu(&dtab->list);
  133. spin_unlock(&dev_map_lock);
  134. synchronize_rcu();
  135. /* To ensure all pending flush operations have completed wait for flush
  136. * bitmap to indicate all flush_needed bits to be zero on _all_ cpus.
  137. * Because the above synchronize_rcu() ensures the map is disconnected
  138. * from the program we can assume no new bits will be set.
  139. */
  140. for_each_online_cpu(cpu) {
  141. unsigned long *bitmap = per_cpu_ptr(dtab->flush_needed, cpu);
  142. while (!bitmap_empty(bitmap, dtab->map.max_entries))
  143. cond_resched();
  144. }
  145. for (i = 0; i < dtab->map.max_entries; i++) {
  146. struct bpf_dtab_netdev *dev;
  147. dev = dtab->netdev_map[i];
  148. if (!dev)
  149. continue;
  150. dev_put(dev->dev);
  151. kfree(dev);
  152. }
  153. free_percpu(dtab->flush_needed);
  154. bpf_map_area_free(dtab->netdev_map);
  155. kfree(dtab);
  156. }
  157. static int dev_map_get_next_key(struct bpf_map *map, void *key, void *next_key)
  158. {
  159. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  160. u32 index = key ? *(u32 *)key : U32_MAX;
  161. u32 *next = next_key;
  162. if (index >= dtab->map.max_entries) {
  163. *next = 0;
  164. return 0;
  165. }
  166. if (index == dtab->map.max_entries - 1)
  167. return -ENOENT;
  168. *next = index + 1;
  169. return 0;
  170. }
  171. void __dev_map_insert_ctx(struct bpf_map *map, u32 bit)
  172. {
  173. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  174. unsigned long *bitmap = this_cpu_ptr(dtab->flush_needed);
  175. __set_bit(bit, bitmap);
  176. }
  177. /* __dev_map_flush is called from xdp_do_flush_map() which _must_ be signaled
  178. * from the driver before returning from its napi->poll() routine. The poll()
  179. * routine is called either from busy_poll context or net_rx_action signaled
  180. * from NET_RX_SOFTIRQ. Either way the poll routine must complete before the
  181. * net device can be torn down. On devmap tear down we ensure the ctx bitmap
  182. * is zeroed before completing to ensure all flush operations have completed.
  183. */
  184. void __dev_map_flush(struct bpf_map *map)
  185. {
  186. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  187. unsigned long *bitmap = this_cpu_ptr(dtab->flush_needed);
  188. u32 bit;
  189. for_each_set_bit(bit, bitmap, map->max_entries) {
  190. struct bpf_dtab_netdev *dev = READ_ONCE(dtab->netdev_map[bit]);
  191. struct net_device *netdev;
  192. /* This is possible if the dev entry is removed by user space
  193. * between xdp redirect and flush op.
  194. */
  195. if (unlikely(!dev))
  196. continue;
  197. __clear_bit(bit, bitmap);
  198. netdev = dev->dev;
  199. if (likely(netdev->netdev_ops->ndo_xdp_flush))
  200. netdev->netdev_ops->ndo_xdp_flush(netdev);
  201. }
  202. }
  203. /* rcu_read_lock (from syscall and BPF contexts) ensures that if a delete and/or
  204. * update happens in parallel here a dev_put wont happen until after reading the
  205. * ifindex.
  206. */
  207. struct net_device *__dev_map_lookup_elem(struct bpf_map *map, u32 key)
  208. {
  209. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  210. struct bpf_dtab_netdev *dev;
  211. if (key >= map->max_entries)
  212. return NULL;
  213. dev = READ_ONCE(dtab->netdev_map[key]);
  214. return dev ? dev->dev : NULL;
  215. }
  216. static void *dev_map_lookup_elem(struct bpf_map *map, void *key)
  217. {
  218. struct net_device *dev = __dev_map_lookup_elem(map, *(u32 *)key);
  219. return dev ? &dev->ifindex : NULL;
  220. }
  221. static void dev_map_flush_old(struct bpf_dtab_netdev *dev)
  222. {
  223. if (dev->dev->netdev_ops->ndo_xdp_flush) {
  224. struct net_device *fl = dev->dev;
  225. unsigned long *bitmap;
  226. int cpu;
  227. for_each_online_cpu(cpu) {
  228. bitmap = per_cpu_ptr(dev->dtab->flush_needed, cpu);
  229. __clear_bit(dev->bit, bitmap);
  230. fl->netdev_ops->ndo_xdp_flush(dev->dev);
  231. }
  232. }
  233. }
  234. static void __dev_map_entry_free(struct rcu_head *rcu)
  235. {
  236. struct bpf_dtab_netdev *dev;
  237. dev = container_of(rcu, struct bpf_dtab_netdev, rcu);
  238. dev_map_flush_old(dev);
  239. dev_put(dev->dev);
  240. kfree(dev);
  241. }
  242. static int dev_map_delete_elem(struct bpf_map *map, void *key)
  243. {
  244. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  245. struct bpf_dtab_netdev *old_dev;
  246. int k = *(u32 *)key;
  247. if (k >= map->max_entries)
  248. return -EINVAL;
  249. /* Use call_rcu() here to ensure any rcu critical sections have
  250. * completed, but this does not guarantee a flush has happened
  251. * yet. Because driver side rcu_read_lock/unlock only protects the
  252. * running XDP program. However, for pending flush operations the
  253. * dev and ctx are stored in another per cpu map. And additionally,
  254. * the driver tear down ensures all soft irqs are complete before
  255. * removing the net device in the case of dev_put equals zero.
  256. */
  257. old_dev = xchg(&dtab->netdev_map[k], NULL);
  258. if (old_dev)
  259. call_rcu(&old_dev->rcu, __dev_map_entry_free);
  260. return 0;
  261. }
  262. static int dev_map_update_elem(struct bpf_map *map, void *key, void *value,
  263. u64 map_flags)
  264. {
  265. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  266. struct net *net = current->nsproxy->net_ns;
  267. struct bpf_dtab_netdev *dev, *old_dev;
  268. u32 i = *(u32 *)key;
  269. u32 ifindex = *(u32 *)value;
  270. if (unlikely(map_flags > BPF_EXIST))
  271. return -EINVAL;
  272. if (unlikely(i >= dtab->map.max_entries))
  273. return -E2BIG;
  274. if (unlikely(map_flags == BPF_NOEXIST))
  275. return -EEXIST;
  276. if (!ifindex) {
  277. dev = NULL;
  278. } else {
  279. dev = kmalloc_node(sizeof(*dev), GFP_ATOMIC | __GFP_NOWARN,
  280. map->numa_node);
  281. if (!dev)
  282. return -ENOMEM;
  283. dev->dev = dev_get_by_index(net, ifindex);
  284. if (!dev->dev) {
  285. kfree(dev);
  286. return -EINVAL;
  287. }
  288. dev->bit = i;
  289. dev->dtab = dtab;
  290. }
  291. /* Use call_rcu() here to ensure rcu critical sections have completed
  292. * Remembering the driver side flush operation will happen before the
  293. * net device is removed.
  294. */
  295. old_dev = xchg(&dtab->netdev_map[i], dev);
  296. if (old_dev)
  297. call_rcu(&old_dev->rcu, __dev_map_entry_free);
  298. return 0;
  299. }
  300. const struct bpf_map_ops dev_map_ops = {
  301. .map_alloc = dev_map_alloc,
  302. .map_free = dev_map_free,
  303. .map_get_next_key = dev_map_get_next_key,
  304. .map_lookup_elem = dev_map_lookup_elem,
  305. .map_update_elem = dev_map_update_elem,
  306. .map_delete_elem = dev_map_delete_elem,
  307. };
  308. static int dev_map_notification(struct notifier_block *notifier,
  309. ulong event, void *ptr)
  310. {
  311. struct net_device *netdev = netdev_notifier_info_to_dev(ptr);
  312. struct bpf_dtab *dtab;
  313. int i;
  314. switch (event) {
  315. case NETDEV_UNREGISTER:
  316. /* This rcu_read_lock/unlock pair is needed because
  317. * dev_map_list is an RCU list AND to ensure a delete
  318. * operation does not free a netdev_map entry while we
  319. * are comparing it against the netdev being unregistered.
  320. */
  321. rcu_read_lock();
  322. list_for_each_entry_rcu(dtab, &dev_map_list, list) {
  323. for (i = 0; i < dtab->map.max_entries; i++) {
  324. struct bpf_dtab_netdev *dev, *odev;
  325. dev = READ_ONCE(dtab->netdev_map[i]);
  326. if (!dev ||
  327. dev->dev->ifindex != netdev->ifindex)
  328. continue;
  329. odev = cmpxchg(&dtab->netdev_map[i], dev, NULL);
  330. if (dev == odev)
  331. call_rcu(&dev->rcu,
  332. __dev_map_entry_free);
  333. }
  334. }
  335. rcu_read_unlock();
  336. break;
  337. default:
  338. break;
  339. }
  340. return NOTIFY_OK;
  341. }
  342. static struct notifier_block dev_map_notifier = {
  343. .notifier_call = dev_map_notification,
  344. };
  345. static int __init dev_map_init(void)
  346. {
  347. register_netdevice_notifier(&dev_map_notifier);
  348. return 0;
  349. }
  350. subsys_initcall(dev_map_init);