소스 검색

drm/omap: hdmi4: fix use of uninitialized var

If use_mclk is false, mclk_mode is written to a register without
initialization. This doesn't cause any ill effects as the written value
is not used when use_mclk is false.

To fix this, write use_mclk only when use_mclk is true.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi Valkeinen 6 년 전
부모
커밋
f4da5b2f4d
1개의 변경된 파일3개의 추가작업 그리고 2개의 파일을 삭제
  1. 3 2
      drivers/gpu/drm/omapdrm/dss/hdmi4_core.c

+ 3 - 2
drivers/gpu/drm/omapdrm/dss/hdmi4_core.c

@@ -553,8 +553,9 @@ static void hdmi_core_audio_config(struct hdmi_core_data *core,
 	}
 	}
 
 
 	/* Set ACR clock divisor */
 	/* Set ACR clock divisor */
-	REG_FLD_MOD(av_base,
-			HDMI_CORE_AV_FREQ_SVAL, cfg->mclk_mode, 2, 0);
+	if (cfg->use_mclk)
+		REG_FLD_MOD(av_base, HDMI_CORE_AV_FREQ_SVAL,
+			    cfg->mclk_mode, 2, 0);
 
 
 	r = hdmi_read_reg(av_base, HDMI_CORE_AV_ACR_CTRL);
 	r = hdmi_read_reg(av_base, HDMI_CORE_AV_ACR_CTRL);
 	/*
 	/*