浏览代码

mmc: core: Prevent processing SDIO IRQs when none is claimed

In cases when MMC_CAP2_SDIO_IRQ_NOTHREAD is set, there is a minor window
for when the mmc host could call sdio_run_irqs(), while in fact an SDIO
func driver could have decided to released the SDIO IRQ via a call to
sdio_release_irq(). In this scenario, processing of the SDIO IRQs are done
even if there is none IRQ claimed, which is not what we want.

To prevent this from happen, close the window by validating that at least
one SDIO IRQs is claimed, before deciding to process them.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Ulf Hansson 8 年之前
父节点
当前提交
e3a84267ab
共有 1 个文件被更改,包括 4 次插入2 次删除
  1. 4 2
      drivers/mmc/core/sdio_irq.c

+ 4 - 2
drivers/mmc/core/sdio_irq.c

@@ -95,8 +95,10 @@ static int process_sdio_pending_irqs(struct mmc_host *host)
 void sdio_run_irqs(struct mmc_host *host)
 void sdio_run_irqs(struct mmc_host *host)
 {
 {
 	mmc_claim_host(host);
 	mmc_claim_host(host);
-	host->sdio_irq_pending = true;
-	process_sdio_pending_irqs(host);
+	if (host->sdio_irqs) {
+		host->sdio_irq_pending = true;
+		process_sdio_pending_irqs(host);
+	}
 	mmc_release_host(host);
 	mmc_release_host(host);
 }
 }
 EXPORT_SYMBOL_GPL(sdio_run_irqs);
 EXPORT_SYMBOL_GPL(sdio_run_irqs);