Просмотр исходного кода

staging: most: Delete an unnecessary check before the function call "module_put"

The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Markus Elfring 10 лет назад
Родитель
Сommit
e23afff948
1 измененных файлов с 1 добавлено и 2 удалено
  1. 1 2
      drivers/staging/most/mostcore/core.c

+ 1 - 2
drivers/staging/most/mostcore/core.c

@@ -1587,8 +1587,7 @@ out:
 	return 0;
 
 error:
-	if (iface->mod)
-		module_put(iface->mod);
+	module_put(iface->mod);
 	modref--;
 	mutex_unlock(&c->start_mutex);
 	return ret;