瀏覽代碼

gpio: GPIOHANDLE_GET_LINE_VALUES_IOCTL: Fix information leak

The GPIOHANDLE_GET_LINE_VALUES_IOCTL handler allocates a gpiohandle_data
struct on the stack and then passes it to copy_to_user(). But only the
first element of the values array in the struct is set, which leaves the
struct partially initialized.

This exposes the previous, potentially sensitive, stack content to the
issuing userspace application. To avoid this make sure that the struct is
fully initialized.

Cc: stable@vger.kernel.org
Fixes: 61f922db7221 ("gpio: userspace ABI for reading GPIO line events")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Lars-Peter Clausen 9 年之前
父節點
當前提交
d82aa4a8f2
共有 1 個文件被更改,包括 2 次插入0 次删除
  1. 2 0
      drivers/gpio/gpiolib.c

+ 2 - 0
drivers/gpio/gpiolib.c

@@ -628,6 +628,8 @@ static long lineevent_ioctl(struct file *filep, unsigned int cmd,
 	if (cmd == GPIOHANDLE_GET_LINE_VALUES_IOCTL) {
 	if (cmd == GPIOHANDLE_GET_LINE_VALUES_IOCTL) {
 		int val;
 		int val;
 
 
+		memset(&ghd, 0, sizeof(ghd));
+
 		val = gpiod_get_value_cansleep(le->desc);
 		val = gpiod_get_value_cansleep(le->desc);
 		if (val < 0)
 		if (val < 0)
 			return val;
 			return val;