瀏覽代碼

cxgb4: Check for kvzalloc allocation failure

t4_prep_fw doesn't check for card_fw pointer before store the read data,
which could lead to a NULL pointer dereference if kvzalloc failed.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
YueHaibing 7 年之前
父節點
當前提交
d624613e42
共有 1 個文件被更改,包括 4 次插入0 次删除
  1. 4 0
      drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

+ 4 - 0
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

@@ -4140,6 +4140,10 @@ static int adap_init0(struct adapter *adap)
 		 * card
 		 * card
 		 */
 		 */
 		card_fw = kvzalloc(sizeof(*card_fw), GFP_KERNEL);
 		card_fw = kvzalloc(sizeof(*card_fw), GFP_KERNEL);
+		if (!card_fw) {
+			ret = -ENOMEM;
+			goto bye;
+		}
 
 
 		/* Get FW from from /lib/firmware/ */
 		/* Get FW from from /lib/firmware/ */
 		ret = request_firmware(&fw, fw_info->fw_mod_name,
 		ret = request_firmware(&fw, fw_info->fw_mod_name,