Browse Source

srcu: Shrink Tiny SRCU a bit

In Tiny SRCU, __srcu_read_lock() is a trivial function, outweighed by
its EXPORT_SYMBOL_GPL(), and on many architectures, its call sequence.
This commit therefore moves it to srcutiny.h so that it can be inlined.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Paul E. McKenney 8 years ago
parent
commit
d4efe6c5ad
2 changed files with 15 additions and 16 deletions
  1. 15 0
      include/linux/srcutiny.h
  2. 0 16
      kernel/rcu/srcutiny.c

+ 15 - 0
include/linux/srcutiny.h

@@ -63,6 +63,21 @@ void srcu_drive_gp(struct work_struct *wp);
 
 
 void synchronize_srcu(struct srcu_struct *sp);
 void synchronize_srcu(struct srcu_struct *sp);
 
 
+/*
+ * Counts the new reader in the appropriate per-CPU element of the
+ * srcu_struct.  Can be invoked from irq/bh handlers, but the matching
+ * __srcu_read_unlock() must be in the same handler instance.  Returns an
+ * index that must be passed to the matching srcu_read_unlock().
+ */
+static inline int __srcu_read_lock(struct srcu_struct *sp)
+{
+	int idx;
+
+	idx = READ_ONCE(sp->srcu_idx);
+	WRITE_ONCE(sp->srcu_lock_nesting[idx], sp->srcu_lock_nesting[idx] + 1);
+	return idx;
+}
+
 static inline void synchronize_srcu_expedited(struct srcu_struct *sp)
 static inline void synchronize_srcu_expedited(struct srcu_struct *sp)
 {
 {
 	synchronize_srcu(sp);
 	synchronize_srcu(sp);

+ 0 - 16
kernel/rcu/srcutiny.c

@@ -95,22 +95,6 @@ void cleanup_srcu_struct(struct srcu_struct *sp)
 }
 }
 EXPORT_SYMBOL_GPL(cleanup_srcu_struct);
 EXPORT_SYMBOL_GPL(cleanup_srcu_struct);
 
 
-/*
- * Counts the new reader in the appropriate per-CPU element of the
- * srcu_struct.  Can be invoked from irq/bh handlers, but the matching
- * __srcu_read_unlock() must be in the same handler instance.  Returns an
- * index that must be passed to the matching srcu_read_unlock().
- */
-int __srcu_read_lock(struct srcu_struct *sp)
-{
-	int idx;
-
-	idx = READ_ONCE(sp->srcu_idx);
-	WRITE_ONCE(sp->srcu_lock_nesting[idx], sp->srcu_lock_nesting[idx] + 1);
-	return idx;
-}
-EXPORT_SYMBOL_GPL(__srcu_read_lock);
-
 /*
 /*
  * Removes the count for the old reader from the appropriate element of
  * Removes the count for the old reader from the appropriate element of
  * the srcu_struct.
  * the srcu_struct.