瀏覽代碼

HID: i2c-hid: Fix error handling

According to error handling in this function, it is likely that some
resources should be freed before returning.
Replace 'return ret', with 'goto err'.

While at it, remove some spaces at the beginning of the lines to be more
consistent.

Fixes: ead0687fe304a ("HID: i2c-hid: support regulator power on/off")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Christophe JAILLET 8 年之前
父節點
當前提交
d3d9adfe30
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/hid/i2c-hid/i2c-hid.c

+ 1 - 1
drivers/hid/i2c-hid/i2c-hid.c

@@ -1064,7 +1064,7 @@ static int i2c_hid_probe(struct i2c_client *client,
 		if (ret != -EPROBE_DEFER)
 		if (ret != -EPROBE_DEFER)
 			dev_err(&client->dev, "Failed to get regulator: %d\n",
 			dev_err(&client->dev, "Failed to get regulator: %d\n",
 				ret);
 				ret);
-		return ret;
+		goto err;
 	}
 	}
 
 
 	ret = regulator_enable(ihid->pdata.supply);
 	ret = regulator_enable(ihid->pdata.supply);