瀏覽代碼

spi/sh-hspi: fix return value check in hspi_probe().

According to its documentation, clk_get() returns a "valid IS_ERR() condition
containing errno", so we should call IS_ERR() rather than a NULL check.

Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Cyril Roelandt 13 年之前
父節點
當前提交
d3601e56cf
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/spi/spi-sh-hspi.c

+ 1 - 1
drivers/spi/spi-sh-hspi.c

@@ -290,7 +290,7 @@ static int hspi_probe(struct platform_device *pdev)
 	}
 	}
 
 
 	clk = clk_get(NULL, "shyway_clk");
 	clk = clk_get(NULL, "shyway_clk");
-	if (!clk) {
+	if (IS_ERR(clk)) {
 		dev_err(&pdev->dev, "shyway_clk is required\n");
 		dev_err(&pdev->dev, "shyway_clk is required\n");
 		ret = -EINVAL;
 		ret = -EINVAL;
 		goto error0;
 		goto error0;