Преглед на файлове

[ALSA] NULL pointer dereference in sound/synth/emux/soundfont.c

this is about coverity id #100.
It seems the if statement is negated, since the else branch calls
remove_info() with sflist->currsf as a parameter where it gets
dereferenced.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Eric Sesterhenn преди 19 години
родител
ревизия
d20cad602f
променени са 1 файла, в които са добавени 1 реда и са изтрити 1 реда
  1. 1 1
      sound/synth/emux/soundfont.c

+ 1 - 1
sound/synth/emux/soundfont.c

@@ -195,7 +195,7 @@ snd_soundfont_load(struct snd_sf_list *sflist, const void __user *data,
 		break;
 		break;
 	case SNDRV_SFNT_REMOVE_INFO:
 	case SNDRV_SFNT_REMOVE_INFO:
 		/* patch must be opened */
 		/* patch must be opened */
-		if (sflist->currsf) {
+		if (!sflist->currsf) {
 			snd_printk("soundfont: remove_info: patch not opened\n");
 			snd_printk("soundfont: remove_info: patch not opened\n");
 			rc = -EINVAL;
 			rc = -EINVAL;
 		} else {
 		} else {