Эх сурвалжийг харах

staging: rtl8188eu: remove unneeded variable

The default value of status was _FAIL, it was only changed if kzalloc
succeeds and the check for status is immediately following kzalloc. We
can have the failure code in the else part as the failure code will be
executed only if kzalloc fails.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee 10 жил өмнө
parent
commit
ce80632273

+ 1 - 5
drivers/staging/rtl8188eu/os_dep/usb_intf.c

@@ -55,7 +55,6 @@ MODULE_DEVICE_TABLE(usb, rtw_usb_id_tbl);
 static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
 static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
 {
 {
 	int	i;
 	int	i;
-	int	status = _FAIL;
 	struct dvobj_priv *pdvobjpriv;
 	struct dvobj_priv *pdvobjpriv;
 	struct usb_host_config		*phost_conf;
 	struct usb_host_config		*phost_conf;
 	struct usb_config_descriptor	*pconf_desc;
 	struct usb_config_descriptor	*pconf_desc;
@@ -117,10 +116,7 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
 
 
 	if (pdvobjpriv->usb_vendor_req_buf) {
 	if (pdvobjpriv->usb_vendor_req_buf) {
 		usb_get_dev(pusbd);
 		usb_get_dev(pusbd);
-		status = _SUCCESS;
-	}
-
-	if (status != _SUCCESS) {
+	} else {
 		usb_set_intfdata(usb_intf, NULL);
 		usb_set_intfdata(usb_intf, NULL);
 		kfree(pdvobjpriv);
 		kfree(pdvobjpriv);
 		pdvobjpriv = NULL;
 		pdvobjpriv = NULL;