浏览代码

mac80211: uninitialized return val in __ieee80211_sta_handle_tspec_ac_params

The return value should be initialized to false so that there's a
valid return value when there are no sessions that need work to be
done on them. Luckily, the side effect of using the uninitialized
value is an extra harmless driver call.

Coverity: CID 1260096
Fixes: 02219b3abca59 ("mac80211: add WMM admission control support")
Signed-off-by: John W. Linville <linville@tuxdriver.com>
[extend commit message]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
John Linville 11 年之前
父节点
当前提交
cc72f6e227
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      net/mac80211/mlme.c

+ 1 - 1
net/mac80211/mlme.c

@@ -1643,7 +1643,7 @@ __ieee80211_sta_handle_tspec_ac_params(struct ieee80211_sub_if_data *sdata)
 {
 {
 	struct ieee80211_local *local = sdata->local;
 	struct ieee80211_local *local = sdata->local;
 	struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
 	struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
-	bool ret;
+	bool ret = false;
 	int ac;
 	int ac;
 
 
 	if (local->hw.queues < IEEE80211_NUM_ACS)
 	if (local->hw.queues < IEEE80211_NUM_ACS)