Pārlūkot izejas kodu

xfs: tiny cleanup for xfs_link

The source and target inodes are guaranteed to never be the same by the VFS,
so no need to check for that (and we would get into bad trouble later anyway
if that were the case).  Also clean up the error handling to use two gotos
instead of nested conditions.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
Christoph Hellwig 17 gadi atpakaļ
vecāks
revīzija
cb3f35bb3b
1 mainītis faili ar 4 papildinājumiem un 2 dzēšanām
  1. 4 2
      fs/xfs/xfs_vnodeops.c

+ 4 - 2
fs/xfs/xfs_vnodeops.c

@@ -2004,8 +2004,10 @@ xfs_link(
 	/* Return through std_return after this point. */
 
 	error = XFS_QM_DQATTACH(mp, sip, 0);
-	if (!error && sip != tdp)
-		error = XFS_QM_DQATTACH(mp, tdp, 0);
+	if (error)
+		goto std_return;
+
+	error = XFS_QM_DQATTACH(mp, tdp, 0);
 	if (error)
 		goto std_return;