Browse Source

spi: dw-pci: fix bug when regs left uninitialized

The commit 04f421e7 "spi: dw: use managed resources" changes drivers to use
managed functions, but seems wasn't properly tested in PCI case. The regs field
of struct dw_spi left uninitialized. Thus, kernel crashes when tries to access
to the SPI controller registers. This patch fixes the issue.

Fixes: 04f421e7 (spi: dw: use managed resources)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Cc: stable@vger.kernel.org
Andy Shevchenko 11 years ago
parent
commit
c9d5d6fe16
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/spi/spi-dw-pci.c

+ 2 - 0
drivers/spi/spi-dw-pci.c

@@ -62,6 +62,8 @@ static int spi_pci_probe(struct pci_dev *pdev,
 	if (ret)
 	if (ret)
 		return ret;
 		return ret;
 
 
+	dws->regs = pcim_iomap_table(pdev)[pci_bar];
+
 	dws->bus_num = 0;
 	dws->bus_num = 0;
 	dws->num_cs = 4;
 	dws->num_cs = 4;
 	dws->irq = pdev->irq;
 	dws->irq = pdev->irq;