Browse Source

thunderbolt: property: Fix a missing check of kzalloc

[ Upstream commit 6183d5a51866f3acdeeb66b75e87d44025b01a55 ]

No check is enforced for the return value of kzalloc,
which may lead to NULL-pointer dereference.

The patch fixes this issue.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Kangjie Lu 6 years ago
parent
commit
c8eecd6582
1 changed files with 6 additions and 1 deletions
  1. 6 1
      drivers/thunderbolt/property.c

+ 6 - 1
drivers/thunderbolt/property.c

@@ -581,7 +581,12 @@ int tb_property_add_text(struct tb_property_dir *parent, const char *key,
 		return -ENOMEM;
 		return -ENOMEM;
 
 
 	property->length = size / 4;
 	property->length = size / 4;
-	property->value.data = kzalloc(size, GFP_KERNEL);
+	property->value.text = kzalloc(size, GFP_KERNEL);
+	if (!property->value.text) {
+		kfree(property);
+		return -ENOMEM;
+	}
+
 	strcpy(property->value.text, text);
 	strcpy(property->value.text, text);
 
 
 	list_add_tail(&property->list, &parent->properties);
 	list_add_tail(&property->list, &parent->properties);