浏览代码

cpuidle / menu: move repeated correction factor check to init

In menu_select function we check for correction factor every time.
If it is zero we are initializing to unity. Hence move it to init function
and initialise by unity, hence avoid repeated comparisons.

Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
Reviewed-by: Tuukka Tikkanen <tuukka.tikkanen@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Chander Kashyap 11 年之前
父节点
当前提交
bed4d597a0
共有 1 个文件被更改,包括 8 次插入7 次删除
  1. 8 7
      drivers/cpuidle/governors/menu.c

+ 8 - 7
drivers/cpuidle/governors/menu.c

@@ -310,13 +310,6 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev)
 
 
 	data->bucket = which_bucket(data->next_timer_us);
 	data->bucket = which_bucket(data->next_timer_us);
 
 
-	/*
-	 * if the correction factor is 0 (eg first time init or cpu hotplug
-	 * etc), we actually want to start out with a unity factor.
-	 */
-	if (data->correction_factor[data->bucket] == 0)
-		data->correction_factor[data->bucket] = RESOLUTION * DECAY;
-
 	/*
 	/*
 	 * Force the result of multiplication to be 64 bits even if both
 	 * Force the result of multiplication to be 64 bits even if both
 	 * operands are 32 bits.
 	 * operands are 32 bits.
@@ -466,9 +459,17 @@ static int menu_enable_device(struct cpuidle_driver *drv,
 				struct cpuidle_device *dev)
 				struct cpuidle_device *dev)
 {
 {
 	struct menu_device *data = &per_cpu(menu_devices, dev->cpu);
 	struct menu_device *data = &per_cpu(menu_devices, dev->cpu);
+	int i;
 
 
 	memset(data, 0, sizeof(struct menu_device));
 	memset(data, 0, sizeof(struct menu_device));
 
 
+	/*
+	 * if the correction factor is 0 (eg first time init or cpu hotplug
+	 * etc), we actually want to start out with a unity factor.
+	 */
+	for(i = 0; i < BUCKETS; i++)
+		data->correction_factor[i] = RESOLUTION * DECAY;
+
 	return 0;
 	return 0;
 }
 }