瀏覽代碼

vfs: show_vfsstat: remove redundant initialization and check of error code

As err variable is now always checked right after each assignment, its
initialization is redundant and could be safely removed.  For the same
reason, the last check of err is also redundant and could be removed as
well.

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Dmitry V. Levin 10 年之前
父節點
當前提交
b896fb35ca
共有 1 個文件被更改,包括 2 次插入3 次删除
  1. 2 3
      fs/proc_namespace.c

+ 2 - 3
fs/proc_namespace.c

@@ -193,7 +193,7 @@ static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt)
 	struct mount *r = real_mount(mnt);
 	struct mount *r = real_mount(mnt);
 	struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt };
 	struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt };
 	struct super_block *sb = mnt_path.dentry->d_sb;
 	struct super_block *sb = mnt_path.dentry->d_sb;
-	int err = 0;
+	int err;
 
 
 	/* device */
 	/* device */
 	if (sb->s_op->show_devname) {
 	if (sb->s_op->show_devname) {
@@ -222,8 +222,7 @@ static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt)
 	/* optional statistics */
 	/* optional statistics */
 	if (sb->s_op->show_stats) {
 	if (sb->s_op->show_stats) {
 		seq_putc(m, ' ');
 		seq_putc(m, ' ');
-		if (!err)
-			err = sb->s_op->show_stats(m, mnt_path.dentry);
+		err = sb->s_op->show_stats(m, mnt_path.dentry);
 	}
 	}
 
 
 	seq_putc(m, '\n');
 	seq_putc(m, '\n');