Przeglądaj źródła

[media] m5mols: introduce missing initialization

The result of one call to a function is tested, and then at the second call
to the same function, the previous result, and not the current result, is
tested again.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression ret;
identifier f;
statement S1,S2;
@@

*ret = f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S1
... when any
*f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Julia Lawall 13 lat temu
rodzic
commit
b25b895805
1 zmienionych plików z 1 dodań i 1 usunięć
  1. 1 1
      drivers/media/i2c/m5mols/m5mols_core.c

+ 1 - 1
drivers/media/i2c/m5mols/m5mols_core.c

@@ -937,7 +937,7 @@ static int __devinit m5mols_probe(struct i2c_client *client,
 	if (!ret)
 	if (!ret)
 		ret = m5mols_init_controls(sd);
 		ret = m5mols_init_controls(sd);
 
 
-	m5mols_sensor_power(info, false);
+	ret = m5mols_sensor_power(info, false);
 	if (!ret)
 	if (!ret)
 		return 0;
 		return 0;
 out_me:
 out_me: