Преглед на файлове

timers/posix-cpu-timers: Use lockdep to assert IRQs are disabled/enabled

Use lockdep to check that IRQs are enabled or disabled as expected. This
way the sanity check only shows overhead when concurrency correctness
debug code is enabled.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: David S . Miller <davem@davemloft.net>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>
Link: http://lkml.kernel.org/r/1509980490-4285-13-git-send-email-frederic@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Frederic Weisbecker преди 8 години
родител
ревизия
a69682200d
променени са 1 файла, в които са добавени 3 реда и са изтрити 3 реда
  1. 3 3
      kernel/time/posix-cpu-timers.c

+ 3 - 3
kernel/time/posix-cpu-timers.c

@@ -603,7 +603,7 @@ static int posix_cpu_timer_set(struct k_itimer *timer, int timer_flags,
 	/*
 	/*
 	 * Disarm any old timer after extracting its expiry time.
 	 * Disarm any old timer after extracting its expiry time.
 	 */
 	 */
-	WARN_ON_ONCE(!irqs_disabled());
+	lockdep_assert_irqs_disabled();
 
 
 	ret = 0;
 	ret = 0;
 	old_incr = timer->it.cpu.incr;
 	old_incr = timer->it.cpu.incr;
@@ -1034,7 +1034,7 @@ static void posix_cpu_timer_rearm(struct k_itimer *timer)
 	/*
 	/*
 	 * Now re-arm for the new expiry time.
 	 * Now re-arm for the new expiry time.
 	 */
 	 */
-	WARN_ON_ONCE(!irqs_disabled());
+	lockdep_assert_irqs_disabled();
 	arm_timer(timer);
 	arm_timer(timer);
 unlock:
 unlock:
 	unlock_task_sighand(p, &flags);
 	unlock_task_sighand(p, &flags);
@@ -1125,7 +1125,7 @@ void run_posix_cpu_timers(struct task_struct *tsk)
 	struct k_itimer *timer, *next;
 	struct k_itimer *timer, *next;
 	unsigned long flags;
 	unsigned long flags;
 
 
-	WARN_ON_ONCE(!irqs_disabled());
+	lockdep_assert_irqs_disabled();
 
 
 	/*
 	/*
 	 * The fast path checks that there are no expired thread or thread
 	 * The fast path checks that there are no expired thread or thread