瀏覽代碼

mm: memcg: do not declare OOM from __GFP_NOFAIL allocations

Commit 84235de394d9 ("fs: buffer: move allocation failure loop into the
allocator") started recognizing __GFP_NOFAIL in memory cgroups but
forgot to disable the OOM killer.

Any task that does not fail allocation will also not enter the OOM
completion path.  So don't declare an OOM state in this case or it'll be
leaked and the task be able to bypass the limit until the next
userspace-triggered page fault cleans up the OOM state.

Reported-by: William Dauchy <wdauchy@gmail.com>
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Michal Hocko <mhocko@suse.cz>
Cc: David Rientjes <rientjes@google.com>
Cc: <stable@vger.kernel.org>	[3.12.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Johannes Weiner 12 年之前
父節點
當前提交
a0d8b00a33
共有 1 個文件被更改,包括 3 次插入0 次删除
  1. 3 0
      mm/memcontrol.c

+ 3 - 0
mm/memcontrol.c

@@ -2696,6 +2696,9 @@ static int __mem_cgroup_try_charge(struct mm_struct *mm,
 	if (unlikely(task_in_memcg_oom(current)))
 	if (unlikely(task_in_memcg_oom(current)))
 		goto bypass;
 		goto bypass;
 
 
+	if (gfp_mask & __GFP_NOFAIL)
+		oom = false;
+
 	/*
 	/*
 	 * We always charge the cgroup the mm_struct belongs to.
 	 * We always charge the cgroup the mm_struct belongs to.
 	 * The mm_struct's mem_cgroup changes on task migration if the
 	 * The mm_struct's mem_cgroup changes on task migration if the