浏览代码

intel_scu_ipc: Protect dev member assignment on ->remove()

Protect the dev member assignment in ->remove() since user may potentially call
unbind from a sysfs even if the driver is built-in. The latter might be racy
with ongoing SCU communication.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Andy Shevchenko 10 年之前
父节点
当前提交
9d1d459bf5
共有 1 个文件被更改,包括 3 次插入0 次删除
  1. 3 0
      drivers/platform/x86/intel_scu_ipc.c

+ 3 - 0
drivers/platform/x86/intel_scu_ipc.c

@@ -625,7 +625,10 @@ static void ipc_remove(struct pci_dev *pdev)
 {
 {
 	struct intel_scu_ipc_dev *scu = pci_get_drvdata(pdev);
 	struct intel_scu_ipc_dev *scu = pci_get_drvdata(pdev);
 
 
+	mutex_lock(&ipclock);
 	scu->dev = NULL;
 	scu->dev = NULL;
+	mutex_unlock(&ipclock);
+
 	iounmap(scu->i2c_base);
 	iounmap(scu->i2c_base);
 	intel_scu_devices_destroy();
 	intel_scu_devices_destroy();
 }
 }