浏览代码

Input: sentelic - silence some underflow warnings

I have a static checker that complains when we check for an upper bound
but don't have a corresponding check for a lower bound.  With this code,
the upper bound check seems not really required, so it is not a bug to
leave the lower bound check out as well.  But let's silence the warning
by making these variables unsigned.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Dan Carpenter 10 年之前
父节点
当前提交
9c8f55798a
共有 1 个文件被更改,包括 8 次插入6 次删除
  1. 8 6
      drivers/input/mouse/sentelic.c

+ 8 - 6
drivers/input/mouse/sentelic.c

@@ -432,7 +432,7 @@ static int fsp_onpad_hscr(struct psmouse *psmouse, bool enable)
 static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,
 static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,
 				   const char *buf, size_t count)
 				   const char *buf, size_t count)
 {
 {
-	int reg, val;
+	unsigned int reg, val;
 	char *rest;
 	char *rest;
 	ssize_t retval;
 	ssize_t retval;
 
 
@@ -440,7 +440,7 @@ static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,
 	if (rest == buf || *rest != ' ' || reg > 0xff)
 	if (rest == buf || *rest != ' ' || reg > 0xff)
 		return -EINVAL;
 		return -EINVAL;
 
 
-	retval = kstrtoint(rest + 1, 16, &val);
+	retval = kstrtouint(rest + 1, 16, &val);
 	if (retval)
 	if (retval)
 		return retval;
 		return retval;
 
 
@@ -476,9 +476,10 @@ static ssize_t fsp_attr_set_getreg(struct psmouse *psmouse, void *data,
 					const char *buf, size_t count)
 					const char *buf, size_t count)
 {
 {
 	struct fsp_data *pad = psmouse->private;
 	struct fsp_data *pad = psmouse->private;
-	int reg, val, err;
+	unsigned int reg, val;
+	int err;
 
 
-	err = kstrtoint(buf, 16, &reg);
+	err = kstrtouint(buf, 16, &reg);
 	if (err)
 	if (err)
 		return err;
 		return err;
 
 
@@ -511,9 +512,10 @@ static ssize_t fsp_attr_show_pagereg(struct psmouse *psmouse,
 static ssize_t fsp_attr_set_pagereg(struct psmouse *psmouse, void *data,
 static ssize_t fsp_attr_set_pagereg(struct psmouse *psmouse, void *data,
 					const char *buf, size_t count)
 					const char *buf, size_t count)
 {
 {
-	int val, err;
+	unsigned int val;
+	int err;
 
 
-	err = kstrtoint(buf, 16, &val);
+	err = kstrtouint(buf, 16, &val);
 	if (err)
 	if (err)
 		return err;
 		return err;