Jelajahi Sumber

dlm: cleanup remove unused code

Smatch complains because "lkb" is never NULL.  Looking at it, the original
code actually adds the new element to the end of the list fine, so we can
just get rid of the if condition.  This code is four years old and no one
has complained so it must work.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David Teigland <teigland@redhat.com>
Dan Carpenter 15 tahun lalu
induk
melakukan
99fb19d49e
1 mengubah file dengan 1 tambahan dan 4 penghapusan
  1. 1 4
      fs/dlm/lock.c

+ 1 - 4
fs/dlm/lock.c

@@ -733,10 +733,7 @@ static void lkb_add_ordered(struct list_head *new, struct list_head *head,
 		if (lkb->lkb_rqmode < mode)
 		if (lkb->lkb_rqmode < mode)
 			break;
 			break;
 
 
-	if (!lkb)
-		list_add_tail(new, head);
-	else
-		__list_add(new, lkb->lkb_statequeue.prev, &lkb->lkb_statequeue);
+	__list_add(new, lkb->lkb_statequeue.prev, &lkb->lkb_statequeue);
 }
 }
 
 
 /* add/remove lkb to rsb's grant/convert/wait queue */
 /* add/remove lkb to rsb's grant/convert/wait queue */