瀏覽代碼

tty: Fold pty pair handling into tty_flush_works()

Perform work flush for both ends of a pty pair within tty_flush_works(),
rather than calling twice.

Reviewed-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Hurley 11 年之前
父節點
當前提交
949aa64ff9
共有 1 個文件被更改,包括 7 次插入5 次删除
  1. 7 5
      drivers/tty/tty_io.c

+ 7 - 5
drivers/tty/tty_io.c

@@ -1584,15 +1584,19 @@ void tty_free_termios(struct tty_struct *tty)
 EXPORT_SYMBOL(tty_free_termios);
 EXPORT_SYMBOL(tty_free_termios);
 
 
 /**
 /**
- *	tty_flush_works		-	flush all works of a tty
- *	@tty: tty device to flush works for
+ *	tty_flush_works		-	flush all works of a tty/pty pair
+ *	@tty: tty device to flush works for (or either end of a pty pair)
  *
  *
- *	Sync flush all works belonging to @tty.
+ *	Sync flush all works belonging to @tty (and the 'other' tty).
  */
  */
 static void tty_flush_works(struct tty_struct *tty)
 static void tty_flush_works(struct tty_struct *tty)
 {
 {
 	flush_work(&tty->SAK_work);
 	flush_work(&tty->SAK_work);
 	flush_work(&tty->hangup_work);
 	flush_work(&tty->hangup_work);
+	if (tty->link) {
+		flush_work(&tty->link->SAK_work);
+		flush_work(&tty->link->hangup_work);
+	}
 }
 }
 
 
 /**
 /**
@@ -1892,8 +1896,6 @@ int tty_release(struct inode *inode, struct file *filp)
 
 
 	/* Wait for pending work before tty destruction commmences */
 	/* Wait for pending work before tty destruction commmences */
 	tty_flush_works(tty);
 	tty_flush_works(tty);
-	if (o_tty)
-		tty_flush_works(o_tty);
 
 
 #ifdef TTY_DEBUG_HANGUP
 #ifdef TTY_DEBUG_HANGUP
 	printk(KERN_DEBUG "%s: %s: freeing structure...\n", __func__, tty_name(tty, buf));
 	printk(KERN_DEBUG "%s: %s: freeing structure...\n", __func__, tty_name(tty, buf));