浏览代码

USB: serial: cp210x: Removing unncessary `usb_reset_device` on startup

This `usb_reset_device` command has been around since the driver was
originally reverse engineered. It doesn't cause much issue on single
interface CP210x devices, but on the CP2105 and CP2108 with 2 and 4
interfaces respectively it will cause instability on enumeration and
delays enumeration noticably. There should be no reason to reset a device
at startup, per the CP210x AN571 spec.

Signed-off-by: Preston Fick <preston.fick@silabs.com>
Cc: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Preston Fick 11 年之前
父节点
当前提交
934ef5aca9
共有 1 个文件被更改,包括 0 次插入3 次删除
  1. 0 3
      drivers/usb/serial/cp210x.c

+ 0 - 3
drivers/usb/serial/cp210x.c

@@ -856,9 +856,6 @@ static int cp210x_startup(struct usb_serial *serial)
 	struct usb_host_interface *cur_altsetting;
 	struct usb_host_interface *cur_altsetting;
 	struct cp210x_serial_private *spriv;
 	struct cp210x_serial_private *spriv;
 
 
-	/* cp210x buffers behave strangely unless device is reset */
-	usb_reset_device(serial->dev);
-
 	spriv = kzalloc(sizeof(*spriv), GFP_KERNEL);
 	spriv = kzalloc(sizeof(*spriv), GFP_KERNEL);
 	if (!spriv)
 	if (!spriv)
 		return -ENOMEM;
 		return -ENOMEM;