Browse Source

net/mlxfw: remove redundant goto on error check

The check to see of err is set and the subsequent goto is extraneous
as the next statement is where the goto is jumping to. Remove this
redundant check and goto.

Detected by CoverityScan, CID#1437734 ("Identical code for
different branches")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Yotam Gigi <yotamg@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Colin Ian King 8 năm trước cách đây
mục cha
commit
928a759593
1 tập tin đã thay đổi với 0 bổ sung2 xóa
  1. 0 2
      drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c

+ 0 - 2
drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c

@@ -492,8 +492,6 @@ static int mlxfw_mfa2_file_cb_offset_xz(const struct mlxfw_mfa2_file *mfa2_file,
 	dec_buf.out_pos = 0;
 	dec_buf.out_size = size;
 	err = mlxfw_mfa2_xz_dec_run(xz_dec, &dec_buf, &finished);
-	if (err)
-		goto out;
 out:
 	xz_dec_end(xz_dec);
 	return err;