Jelajahi Sumber

net: pxa168_eth: Use kcalloc() in two functions

Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Markus Elfring 8 tahun lalu
induk
melakukan
91acebedbd
1 mengubah file dengan 2 tambahan dan 4 penghapusan
  1. 2 4
      drivers/net/ethernet/marvell/pxa168_eth.c

+ 2 - 4
drivers/net/ethernet/marvell/pxa168_eth.c

@@ -1036,8 +1036,7 @@ static int rxq_init(struct net_device *dev)
 	int rx_desc_num = pep->rx_ring_size;
 	int rx_desc_num = pep->rx_ring_size;
 
 
 	/* Allocate RX skb rings */
 	/* Allocate RX skb rings */
-	pep->rx_skb = kzalloc(sizeof(*pep->rx_skb) * pep->rx_ring_size,
-			     GFP_KERNEL);
+	pep->rx_skb = kcalloc(rx_desc_num, sizeof(*pep->rx_skb), GFP_KERNEL);
 	if (!pep->rx_skb)
 	if (!pep->rx_skb)
 		return -ENOMEM;
 		return -ENOMEM;
 
 
@@ -1096,8 +1095,7 @@ static int txq_init(struct net_device *dev)
 	int size = 0, i = 0;
 	int size = 0, i = 0;
 	int tx_desc_num = pep->tx_ring_size;
 	int tx_desc_num = pep->tx_ring_size;
 
 
-	pep->tx_skb = kzalloc(sizeof(*pep->tx_skb) * pep->tx_ring_size,
-			     GFP_KERNEL);
+	pep->tx_skb = kcalloc(tx_desc_num, sizeof(*pep->tx_skb), GFP_KERNEL);
 	if (!pep->tx_skb)
 	if (!pep->tx_skb)
 		return -ENOMEM;
 		return -ENOMEM;