Просмотр исходного кода

Input: synaptics-rmi4 - do not check for NULL when calling of_node_put()

The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Markus Elfring 9 лет назад
Родитель
Сommit
887ec0bfbd
1 измененных файлов с 1 добавлено и 4 удалено
  1. 1 4
      drivers/input/rmi4/rmi_bus.c

+ 1 - 4
drivers/input/rmi4/rmi_bus.c

@@ -232,10 +232,7 @@ err_put_device:
 void rmi_unregister_function(struct rmi_function *fn)
 {
 	device_del(&fn->dev);
-
-	if (fn->dev.of_node)
-		of_node_put(fn->dev.of_node);
-
+	of_node_put(fn->dev.of_node);
 	put_device(&fn->dev);
 }