Răsfoiți Sursa

xen: fix potential integer overflow in queue_reply

When len is greater than UINT_MAX - sizeof(*rb), in next allocation,
it can overflow integer range and allocates small size of heap.
After that, memcpy will overflow the allocated heap.
Therefore, it needs to check the size of given length.

Signed-off-by: Insu Yun <wuninsu@gmail.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Insu Yun 10 ani în urmă
părinte
comite
85c0a87cd1
1 a modificat fișierele cu 2 adăugiri și 0 ștergeri
  1. 2 0
      drivers/xen/xenbus/xenbus_dev_frontend.c

+ 2 - 0
drivers/xen/xenbus/xenbus_dev_frontend.c

@@ -188,6 +188,8 @@ static int queue_reply(struct list_head *queue, const void *data, size_t len)
 
 	if (len == 0)
 		return 0;
+	if (len > XENSTORE_PAYLOAD_MAX)
+		return -EINVAL;
 
 	rb = kmalloc(sizeof(*rb) + len, GFP_KERNEL);
 	if (rb == NULL)