Переглянути джерело

ARM: missing ->mmap_sem around find_vma() in swp_emulate.c

find_vma() is *not* safe when somebody else is removing vmas.  Not just
the return value might get bogus just as you are getting it (this instance
doesn't try to dereference the resulting vma), the search itself can get
buggered in rather spectacular ways.  IOW, ->mmap_sem really, really is
not optional here.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: <stable@vger.kernel.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Al Viro 13 роки тому
батько
коміт
7bf9b7bef8
1 змінених файлів з 2 додано та 0 видалено
  1. 2 0
      arch/arm/kernel/swp_emulate.c

+ 2 - 0
arch/arm/kernel/swp_emulate.c

@@ -109,10 +109,12 @@ static void set_segfault(struct pt_regs *regs, unsigned long addr)
 {
 {
 	siginfo_t info;
 	siginfo_t info;
 
 
+	down_read(&current->mm->mmap_sem);
 	if (find_vma(current->mm, addr) == NULL)
 	if (find_vma(current->mm, addr) == NULL)
 		info.si_code = SEGV_MAPERR;
 		info.si_code = SEGV_MAPERR;
 	else
 	else
 		info.si_code = SEGV_ACCERR;
 		info.si_code = SEGV_ACCERR;
+	up_read(&current->mm->mmap_sem);
 
 
 	info.si_signo = SIGSEGV;
 	info.si_signo = SIGSEGV;
 	info.si_errno = 0;
 	info.si_errno = 0;