Browse Source

ARM: OMAP: Use kcalloc() in omap_system_dma_probe()

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Markus Elfring 8 years ago
parent
commit
738c985d85
1 changed files with 3 additions and 2 deletions
  1. 3 2
      arch/arm/plat-omap/dma.c

+ 3 - 2
arch/arm/plat-omap/dma.c

@@ -1321,8 +1321,9 @@ static int omap_system_dma_probe(struct platform_device *pdev)
 		return -ENOMEM;
 		return -ENOMEM;
 
 
 	if (dma_omap2plus()) {
 	if (dma_omap2plus()) {
-		dma_linked_lch = kzalloc(sizeof(struct dma_link_info) *
-						dma_lch_count, GFP_KERNEL);
+		dma_linked_lch = kcalloc(dma_lch_count,
+					 sizeof(*dma_linked_lch),
+					 GFP_KERNEL);
 		if (!dma_linked_lch) {
 		if (!dma_linked_lch) {
 			ret = -ENOMEM;
 			ret = -ENOMEM;
 			goto exit_dma_lch_fail;
 			goto exit_dma_lch_fail;