Procházet zdrojové kódy

dmaengine: dmatest: Remove use of VLAs

There's an ongoing effort to remove VLAs from the kernel
(https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla.
The test already pre-allocates some buffers with kmalloc so turn
the two VLAs in to pre-allocated kmalloc buffers.

Signed-off-by: Laura Abbott <labbott@redhat.com>
Reviewed-by: Sinan Kaya <okaya@codeaurora.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Laura Abbott před 7 roky
rodič
revize
72ef08bf65
1 změnil soubory, kde provedl 13 přidání a 3 odebrání
  1. 13 3
      drivers/dma/dmatest.c

+ 13 - 3
drivers/dma/dmatest.c

@@ -468,6 +468,8 @@ static int dmatest_func(void *data)
 	unsigned long long	total_len = 0;
 	unsigned long long	total_len = 0;
 	u8			align = 0;
 	u8			align = 0;
 	bool			is_memset = false;
 	bool			is_memset = false;
+	dma_addr_t		*srcs;
+	dma_addr_t		*dma_pq;
 
 
 	set_freezable();
 	set_freezable();
 
 
@@ -551,6 +553,14 @@ static int dmatest_func(void *data)
 
 
 	set_user_nice(current, 10);
 	set_user_nice(current, 10);
 
 
+	srcs = kcalloc(src_cnt, sizeof(dma_addr_t), GFP_KERNEL);
+	if (!srcs)
+		goto err_dstbuf;
+
+	dma_pq = kcalloc(dst_cnt, sizeof(dma_addr_t), GFP_KERNEL);
+	if (!dma_pq)
+		goto err_srcs_array;
+
 	/*
 	/*
 	 * src and dst buffers are freed by ourselves below
 	 * src and dst buffers are freed by ourselves below
 	 */
 	 */
@@ -561,7 +571,6 @@ static int dmatest_func(void *data)
 	       && !(params->iterations && total_tests >= params->iterations)) {
 	       && !(params->iterations && total_tests >= params->iterations)) {
 		struct dma_async_tx_descriptor *tx = NULL;
 		struct dma_async_tx_descriptor *tx = NULL;
 		struct dmaengine_unmap_data *um;
 		struct dmaengine_unmap_data *um;
-		dma_addr_t srcs[src_cnt];
 		dma_addr_t *dsts;
 		dma_addr_t *dsts;
 		unsigned int src_off, dst_off, len;
 		unsigned int src_off, dst_off, len;
 
 
@@ -676,8 +685,6 @@ static int dmatest_func(void *data)
 						      srcs, src_cnt,
 						      srcs, src_cnt,
 						      len, flags);
 						      len, flags);
 		else if (thread->type == DMA_PQ) {
 		else if (thread->type == DMA_PQ) {
-			dma_addr_t dma_pq[dst_cnt];
-
 			for (i = 0; i < dst_cnt; i++)
 			for (i = 0; i < dst_cnt; i++)
 				dma_pq[i] = dsts[i] + dst_off;
 				dma_pq[i] = dsts[i] + dst_off;
 			tx = dev->device_prep_dma_pq(chan, dma_pq, srcs,
 			tx = dev->device_prep_dma_pq(chan, dma_pq, srcs,
@@ -779,6 +786,9 @@ static int dmatest_func(void *data)
 	runtime = ktime_to_us(ktime);
 	runtime = ktime_to_us(ktime);
 
 
 	ret = 0;
 	ret = 0;
+	kfree(dma_pq);
+err_srcs_array:
+	kfree(srcs);
 err_dstbuf:
 err_dstbuf:
 	for (i = 0; thread->udsts[i]; i++)
 	for (i = 0; thread->udsts[i]; i++)
 		kfree(thread->udsts[i]);
 		kfree(thread->udsts[i]);