Просмотр исходного кода

mac80211-hwsim: remove unnecessary hwname check

The hwname will always be set if idx is negative (as it's
a u32 read into an s64 it can't overflow either) so we can
remove the unnecessary check for hwname being non-NULL.

This was reported by smatch.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Johannes Berg 11 лет назад
Родитель
Сommit
6b67e01fc0
1 измененных файлов с 1 добавлено и 2 удалено
  1. 1 2
      drivers/net/wireless/mac80211_hwsim.c

+ 1 - 2
drivers/net/wireless/mac80211_hwsim.c

@@ -2808,8 +2808,7 @@ static int hwsim_del_radio_nl(struct sk_buff *msg, struct genl_info *info)
 			if (data->idx != idx)
 				continue;
 		} else {
-			if (hwname &&
-			    strcmp(hwname, wiphy_name(data->hw->wiphy)))
+			if (strcmp(hwname, wiphy_name(data->hw->wiphy)))
 				continue;
 		}