Browse Source

ia64/err-inject: Use get_user_pages_fast()

At the point of sysfs callback, the call to gup is
done without mmap_sem (or any lock for that matter).
This is racy. As such, use the get_user_pages_fast()
alternative and safely avoid taking the lock, if possible.

Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Davidlohr Bueso 8 years ago
parent
commit
69c907022a
1 changed files with 1 additions and 1 deletions
  1. 1 1
      arch/ia64/kernel/err_inject.c

+ 1 - 1
arch/ia64/kernel/err_inject.c

@@ -142,7 +142,7 @@ store_virtual_to_phys(struct device *dev, struct device_attribute *attr,
 	u64 virt_addr=simple_strtoull(buf, NULL, 16);
 	u64 virt_addr=simple_strtoull(buf, NULL, 16);
 	int ret;
 	int ret;
 
 
-	ret = get_user_pages(virt_addr, 1, FOLL_WRITE, NULL, NULL);
+	ret = get_user_pages_fast(virt_addr, 1, FOLL_WRITE, NULL);
 	if (ret<=0) {
 	if (ret<=0) {
 #ifdef ERR_INJ_DEBUG
 #ifdef ERR_INJ_DEBUG
 		printk("Virtual address %lx is not existing.\n",virt_addr);
 		printk("Virtual address %lx is not existing.\n",virt_addr);