Jelajahi Sumber

PCI: spear: Use BUG_ON() instead of condition followed by BUG()

Use BUG_ON() instead of an if condition followed by BUG().

The semantic patch that makes this change is available in
scripts/coccinelle/misc/bugon.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: Pratyush Anand <pratyush.anand@gmail.com>
Fabio Estevam 10 tahun lalu
induk
melakukan
68ebb7ce39
1 mengubah file dengan 1 tambahan dan 2 penghapusan
  1. 1 2
      drivers/pci/host/pcie-spear13xx.c

+ 1 - 2
drivers/pci/host/pcie-spear13xx.c

@@ -223,8 +223,7 @@ static irqreturn_t spear13xx_pcie_irq_handler(int irq, void *arg)
 	status = readl(&app_reg->int_sts);
 
 	if (status & MSI_CTRL_INT) {
-		if (!IS_ENABLED(CONFIG_PCI_MSI))
-			BUG();
+		BUG_ON(!IS_ENABLED(CONFIG_PCI_MSI));
 		dw_handle_msi_irq(pp);
 	}