浏览代码

ALSA: asihpi - use kzalloc()

 Use kzalloc rather than kmalloc followed by memset with 0

 This considers some simple cases that are common and easy to validate
 Note in particular that there are no ...s in the rule, so all of the
 matched code has to be contiguous

 The semantic patch that makes this output is available
 in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.

 More information about semantic patching is available at
 http://coccinelle.lip6.fr/

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Thomas Meyer 14 年之前
父节点
当前提交
67ada8367c
共有 1 个文件被更改,包括 2 次插入3 次删除
  1. 2 3
      sound/pci/asihpi/hpicmn.c

+ 2 - 3
sound/pci/asihpi/hpicmn.c

@@ -631,13 +631,12 @@ struct hpi_control_cache *hpi_alloc_control_cache(const u32 control_count,
 	if (!p_cache)
 	if (!p_cache)
 		return NULL;
 		return NULL;
 
 
-	p_cache->p_info =
-		kmalloc(sizeof(*p_cache->p_info) * control_count, GFP_KERNEL);
+	p_cache->p_info = kzalloc(sizeof(*p_cache->p_info) * control_count,
+				  GFP_KERNEL);
 	if (!p_cache->p_info) {
 	if (!p_cache->p_info) {
 		kfree(p_cache);
 		kfree(p_cache);
 		return NULL;
 		return NULL;
 	}
 	}
-	memset(p_cache->p_info, 0, sizeof(*p_cache->p_info) * control_count);
 	p_cache->cache_size_in_bytes = size_in_bytes;
 	p_cache->cache_size_in_bytes = size_in_bytes;
 	p_cache->control_count = control_count;
 	p_cache->control_count = control_count;
 	p_cache->p_cache = p_dsp_control_buffer;
 	p_cache->p_cache = p_dsp_control_buffer;