Ver código fonte

[media] gscpa_m5602: use msecs_to_jiffies for conversions

API compliance scanning with coccinelle flagged:
./drivers/media/usb/gspca/m5602/m5602_s5k83a.c:180:9-25:
	 WARNING: timeout (100) seems HZ dependent

Numeric constants passed to schedule_timeout() make the effective
timeout HZ dependent which makes little sense in a polling loop for
the cameras rotation state.
Fixed up by converting the constant to jiffies with msecs_to_jiffies()

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Nicholas Mc Guire 10 anos atrás
pai
commit
63f2f41752
1 arquivos alterados com 1 adições e 1 exclusões
  1. 1 1
      drivers/media/usb/gspca/m5602/m5602_s5k83a.c

+ 1 - 1
drivers/media/usb/gspca/m5602/m5602_s5k83a.c

@@ -177,7 +177,7 @@ static int rotation_thread_function(void *data)
 	__s32 vflip, hflip;
 	__s32 vflip, hflip;
 
 
 	set_current_state(TASK_INTERRUPTIBLE);
 	set_current_state(TASK_INTERRUPTIBLE);
-	while (!schedule_timeout(100)) {
+	while (!schedule_timeout(msecs_to_jiffies(100))) {
 		if (mutex_lock_interruptible(&sd->gspca_dev.usb_lock))
 		if (mutex_lock_interruptible(&sd->gspca_dev.usb_lock))
 			break;
 			break;