浏览代码

UBI: fix rb_tree node comparison in add_map

The comparisons used in add_vol() shouldn't be identical.  Pretty sure
the following is correct but it is completely untested.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Mike Snitzer 11 年之前
父节点
当前提交
604b592e6f
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/mtd/ubi/fastmap.c

+ 2 - 2
drivers/mtd/ubi/fastmap.c

@@ -125,9 +125,9 @@ static struct ubi_ainf_volume *add_vol(struct ubi_attach_info *ai, int vol_id,
 		parent = *p;
 		parent = *p;
 		av = rb_entry(parent, struct ubi_ainf_volume, rb);
 		av = rb_entry(parent, struct ubi_ainf_volume, rb);
 
 
-		if (vol_id > av->vol_id)
+		if (vol_id < av->vol_id)
 			p = &(*p)->rb_left;
 			p = &(*p)->rb_left;
-		else if (vol_id > av->vol_id)
+		else
 			p = &(*p)->rb_right;
 			p = &(*p)->rb_right;
 	}
 	}