浏览代码

pinctrl: mediatek: fix dual-edge code defect

When a dual-edge irq is triggered, an incorrect irq will be reported on
condition that the external signal is not stable and this incorrect irq
has been registered.
Correct the register offset.

Cc: stable@vger.kernel.org
Signed-off-by: Hongkun Cao <hongkun.cao@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
hongkun.cao 9 年之前
父节点
当前提交
5edf673d07
共有 1 个文件被更改,包括 3 次插入2 次删除
  1. 3 2
      drivers/pinctrl/mediatek/pinctrl-mtk-common.c

+ 3 - 2
drivers/pinctrl/mediatek/pinctrl-mtk-common.c

@@ -1256,9 +1256,10 @@ static void mtk_eint_irq_handler(struct irq_desc *desc)
 	const struct mtk_desc_pin *pin;
 	const struct mtk_desc_pin *pin;
 
 
 	chained_irq_enter(chip, desc);
 	chained_irq_enter(chip, desc);
-	for (eint_num = 0; eint_num < pctl->devdata->ap_num; eint_num += 32) {
+	for (eint_num = 0;
+	     eint_num < pctl->devdata->ap_num;
+	     eint_num += 32, reg += 4) {
 		status = readl(reg);
 		status = readl(reg);
-		reg += 4;
 		while (status) {
 		while (status) {
 			offset = __ffs(status);
 			offset = __ffs(status);
 			index = eint_num + offset;
 			index = eint_num + offset;