Эх сурвалжийг харах

ARM: s3c24xx: Fix boolean expressions in osiris_dvs_notify

commit e2477233145f2156434afb799583bccd878f3e9f upstream.

Fix boolean expressions by using logical AND operator '&&' instead of
bitwise operator '&'.

This issue was detected with the help of Coccinelle.

Fixes: 4fa084af28ca ("ARM: OSIRIS: DVS (Dynamic Voltage Scaling) supoort.")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
[krzk: Fix -Wparentheses warning]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gustavo A. R. Silva 7 жил өмнө
parent
commit
58691e6a93

+ 4 - 4
arch/arm/mach-s3c24xx/mach-osiris-dvs.c

@@ -65,16 +65,16 @@ static int osiris_dvs_notify(struct notifier_block *nb,
 
 
 	switch (val) {
 	switch (val) {
 	case CPUFREQ_PRECHANGE:
 	case CPUFREQ_PRECHANGE:
-		if (old_dvs & !new_dvs ||
-		    cur_dvs & !new_dvs) {
+		if ((old_dvs && !new_dvs) ||
+		    (cur_dvs && !new_dvs)) {
 			pr_debug("%s: exiting dvs\n", __func__);
 			pr_debug("%s: exiting dvs\n", __func__);
 			cur_dvs = false;
 			cur_dvs = false;
 			gpio_set_value(OSIRIS_GPIO_DVS, 1);
 			gpio_set_value(OSIRIS_GPIO_DVS, 1);
 		}
 		}
 		break;
 		break;
 	case CPUFREQ_POSTCHANGE:
 	case CPUFREQ_POSTCHANGE:
-		if (!old_dvs & new_dvs ||
-		    !cur_dvs & new_dvs) {
+		if ((!old_dvs && new_dvs) ||
+		    (!cur_dvs && new_dvs)) {
 			pr_debug("entering dvs\n");
 			pr_debug("entering dvs\n");
 			cur_dvs = true;
 			cur_dvs = true;
 			gpio_set_value(OSIRIS_GPIO_DVS, 0);
 			gpio_set_value(OSIRIS_GPIO_DVS, 0);