Browse Source

mwifiex: Remove casts of pointer to same type

Casting a pointer to a pointer of the same type is pointless,
so remove these unnecessary casts.

Done via coccinelle script:

$ cat typecast_2.cocci
@@
type T;
T *foo;
@@

-	(T *)foo
+	foo

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Joe Perches 11 years ago
parent
commit
45d18c562a

+ 3 - 3
drivers/net/wireless/mwifiex/pcie.c

@@ -1033,7 +1033,7 @@ static int mwifiex_pcie_send_data_complete(struct mwifiex_adapter *adapter)
 		card->tx_buf_list[wrdoneidx] = NULL;
 		card->tx_buf_list[wrdoneidx] = NULL;
 
 
 		if (reg->pfu_enabled) {
 		if (reg->pfu_enabled) {
-			desc2 = (void *)card->txbd_ring[wrdoneidx];
+			desc2 = card->txbd_ring[wrdoneidx];
 			memset(desc2, 0, sizeof(*desc2));
 			memset(desc2, 0, sizeof(*desc2));
 		} else {
 		} else {
 			desc = card->txbd_ring[wrdoneidx];
 			desc = card->txbd_ring[wrdoneidx];
@@ -1118,7 +1118,7 @@ mwifiex_pcie_send_data(struct mwifiex_adapter *adapter, struct sk_buff *skb,
 		card->tx_buf_list[wrindx] = skb;
 		card->tx_buf_list[wrindx] = skb;
 
 
 		if (reg->pfu_enabled) {
 		if (reg->pfu_enabled) {
-			desc2 = (void *)card->txbd_ring[wrindx];
+			desc2 = card->txbd_ring[wrindx];
 			desc2->paddr = buf_pa;
 			desc2->paddr = buf_pa;
 			desc2->len = (u16)skb->len;
 			desc2->len = (u16)skb->len;
 			desc2->frag_len = (u16)skb->len;
 			desc2->frag_len = (u16)skb->len;
@@ -1278,7 +1278,7 @@ static int mwifiex_pcie_process_recv_data(struct mwifiex_adapter *adapter)
 		card->rx_buf_list[rd_index] = skb_tmp;
 		card->rx_buf_list[rd_index] = skb_tmp;
 
 
 		if (reg->pfu_enabled) {
 		if (reg->pfu_enabled) {
-			desc2 = (void *)card->rxbd_ring[rd_index];
+			desc2 = card->rxbd_ring[rd_index];
 			desc2->paddr = buf_pa;
 			desc2->paddr = buf_pa;
 			desc2->len = skb_tmp->len;
 			desc2->len = skb_tmp->len;
 			desc2->frag_len = skb_tmp->len;
 			desc2->frag_len = skb_tmp->len;

+ 1 - 1
drivers/net/wireless/mwifiex/scan.c

@@ -1653,7 +1653,7 @@ mwifiex_parse_single_response_buf(struct mwifiex_private *priv, u8 **bss_info,
 	curr_bcn_bytes -= ETH_ALEN;
 	curr_bcn_bytes -= ETH_ALEN;
 
 
 	if (!ext_scan) {
 	if (!ext_scan) {
-		rssi = (s32) *(u8 *)current_ptr;
+		rssi = (s32) *current_ptr;
 		rssi = (-rssi) * 100;		/* Convert dBm to mBm */
 		rssi = (-rssi) * 100;		/* Convert dBm to mBm */
 		current_ptr += sizeof(u8);
 		current_ptr += sizeof(u8);
 		curr_bcn_bytes -= sizeof(u8);
 		curr_bcn_bytes -= sizeof(u8);

+ 3 - 3
drivers/net/wireless/mwifiex/tdls.c

@@ -730,13 +730,13 @@ void mwifiex_process_tdls_action_frame(struct mwifiex_private *priv,
 
 
 	if (len < (sizeof(struct ethhdr) + 3))
 	if (len < (sizeof(struct ethhdr) + 3))
 		return;
 		return;
-	if (*(u8 *)(buf + sizeof(struct ethhdr)) != WLAN_TDLS_SNAP_RFTYPE)
+	if (*(buf + sizeof(struct ethhdr)) != WLAN_TDLS_SNAP_RFTYPE)
 		return;
 		return;
-	if (*(u8 *)(buf + sizeof(struct ethhdr) + 1) != WLAN_CATEGORY_TDLS)
+	if (*(buf + sizeof(struct ethhdr) + 1) != WLAN_CATEGORY_TDLS)
 		return;
 		return;
 
 
 	peer = buf + ETH_ALEN;
 	peer = buf + ETH_ALEN;
-	action = *(u8 *)(buf + sizeof(struct ethhdr) + 2);
+	action = *(buf + sizeof(struct ethhdr) + 2);
 
 
 	/* just handle TDLS setup request/response/confirm */
 	/* just handle TDLS setup request/response/confirm */
 	if (action > WLAN_TDLS_SETUP_CONFIRM)
 	if (action > WLAN_TDLS_SETUP_CONFIRM)