浏览代码

crypto: omap-des - fix BUG_ON condition

dd->total is unsigned so it won't do any good to check for negative
value after subtracting instead of that we should check if the
subtracted value is bigger than him

This was partially found by using a static code analysis program
called cppcheck.

Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Asaf Vertz 11 年之前
父节点
当前提交
42d2e780c6
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/crypto/omap-des.c

+ 2 - 2
drivers/crypto/omap-des.c

@@ -965,9 +965,9 @@ static irqreturn_t omap_des_irq(int irq, void *dev_id)
 			}
 			}
 		}
 		}
 
 
-		dd->total -= DES_BLOCK_SIZE;
+		BUG_ON(dd->total < DES_BLOCK_SIZE);
 
 
-		BUG_ON(dd->total < 0);
+		dd->total -= DES_BLOCK_SIZE;
 
 
 		/* Clear IRQ status */
 		/* Clear IRQ status */
 		status &= ~DES_REG_IRQ_DATA_OUT;
 		status &= ~DES_REG_IRQ_DATA_OUT;