Преглед изворни кода

ARM: 6653/1: bitops: Use BX instead of MOV PC,LR

The kernel doesn't officially need to interwork, but using BX
wherever appropriate will help educate people into good assembler
coding habits.

BX is appropriate here because this code is predicated on
__LINUX_ARM_ARCH__ >= 6

Signed-off-by: Dave Martin <dave.martin@linaro.org>
Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Dave Martin пре 15 година
родитељ
комит
3ba6e69ad8
1 измењених фајлова са 2 додато и 2 уклоњено
  1. 2 2
      arch/arm/lib/bitops.h

+ 2 - 2
arch/arm/lib/bitops.h

@@ -12,7 +12,7 @@
 	strex	r0, r2, [r1]
 	strex	r0, r2, [r1]
 	cmp	r0, #0
 	cmp	r0, #0
 	bne	1b
 	bne	1b
-	mov	pc, lr
+	bx	lr
 	.endm
 	.endm
 
 
 	.macro	testop, instr, store
 	.macro	testop, instr, store
@@ -33,7 +33,7 @@
 	smp_dmb
 	smp_dmb
 	cmp	r0, #0
 	cmp	r0, #0
 	movne	r0, #1
 	movne	r0, #1
-2:	mov	pc, lr
+2:	bx	lr
 	.endm
 	.endm
 #else
 #else
 	.macro	bitop, instr
 	.macro	bitop, instr