瀏覽代碼

mtd: cfi_cmdset_0002: allow retry/timeout loop to exit

The variable 'retries' is never modified, so if the reset operation
never is going to complete, we'll get stuck in an infinite loop.

It looks like the intention was to decrement 'retries' on every loop.
Untested.

Caught by Coverity.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Brian Norris 11 年之前
父節點
當前提交
36c6a7ac74
共有 1 個文件被更改,包括 2 次插入0 次删除
  1. 2 0
      drivers/mtd/chips/cfi_cmdset_0002.c

+ 2 - 0
drivers/mtd/chips/cfi_cmdset_0002.c

@@ -2029,6 +2029,8 @@ static int cfi_amdstd_panic_wait(struct map_info *map, struct flchip *chip,
 
 			udelay(1);
 		}
+
+		retries--;
 	}
 
 	/* the chip never became ready */