Browse Source

usb: gadget: f_fs: fix check in read operation

when copying to iter the size can be different then the iov count,
the check for full iov is wrong and make any read on request which
is not the exactly size of iov to return -EFAULT.

So, just check the success of the copy.

Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Rui Miguel Silva 10 years ago
parent
commit
342f39a6c8
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/usb/gadget/function/f_fs.c

+ 1 - 1
drivers/usb/gadget/function/f_fs.c

@@ -846,7 +846,7 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data)
 				ret = ep->status;
 				if (io_data->read && ret > 0) {
 					ret = copy_to_iter(data, ret, &io_data->data);
-					if (unlikely(iov_iter_count(&io_data->data)))
+					if (!ret)
 						ret = -EFAULT;
 				}
 			}