浏览代码

[media] gpsca: remove the risk of a division by zero

As reported by Coverity, there's a potential risk of a division
by zero on some calls to jpeg_set_qual(), if quality is zero.

As quality can't be 0 or lower than that, adds an extra clause
to cover this special case.

Coverity reports: CID#11922280, CID#11922293, CID#11922295

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab 11 年之前
父节点
当前提交
32654fba2f
共有 1 个文件被更改,包括 3 次插入1 次删除
  1. 3 1
      drivers/media/usb/gspca/jpeg.h

+ 3 - 1
drivers/media/usb/gspca/jpeg.h

@@ -154,7 +154,9 @@ static void jpeg_set_qual(u8 *jpeg_hdr,
 {
 {
 	int i, sc;
 	int i, sc;
 
 
-	if (quality < 50)
+	if (quality <= 0)
+		sc = 5000;
+	else if (quality < 50)
 		sc = 5000 / quality;
 		sc = 5000 / quality;
 	else
 	else
 		sc = 200 - quality * 2;
 		sc = 200 - quality * 2;