Browse Source

nfp: cast sizeof() to int when comparing with error code

sizeof() will return unsigned value so in the error check
negative error code will be always larger than sizeof().

Fixes: a0d8e02c35ff ("nfp: add support for reading nffw info")

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Chengguang Xu 7 years ago
parent
commit
2d2595719a
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c

+ 1 - 1
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c

@@ -232,7 +232,7 @@ struct nfp_nffw_info *nfp_nffw_info_open(struct nfp_cpp *cpp)
 	err = nfp_cpp_read(cpp, nfp_resource_cpp_id(state->res),
 			   nfp_resource_address(state->res),
 			   fwinf, sizeof(*fwinf));
-	if (err < sizeof(*fwinf))
+	if (err < (int)sizeof(*fwinf))
 		goto err_release;
 
 	if (!nffw_res_flg_init_get(fwinf))