瀏覽代碼

MIPS: avoid possible resource conflict in register_pci_controller

The IO and memory resources of a PCI controller
might already have a parent resource set when
they are passed to 'register_pci_controller'.

If the parent resource is set, the request_resource
call will fail due to resource conflict and the
current code will not be able to register the
PCI controller.

Use the parent resource if it is available in the
request_resource call to avoid the isssue.

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Patchwork: http://patchwork.linux-mips.org/patch/4910/
Signed-off-by: John Crispin <blogic@openwrt.org>
Gabor Juhos 13 年之前
父節點
當前提交
2228317877
共有 1 個文件被更改,包括 13 次插入2 次删除
  1. 13 2
      arch/mips/pci/pci.c

+ 13 - 2
arch/mips/pci/pci.c

@@ -175,9 +175,20 @@ static DEFINE_MUTEX(pci_scan_mutex);
 
 
 void register_pci_controller(struct pci_controller *hose)
 void register_pci_controller(struct pci_controller *hose)
 {
 {
-	if (request_resource(&iomem_resource, hose->mem_resource) < 0)
+	struct resource *parent;
+
+	parent = hose->mem_resource->parent;
+	if (!parent)
+		parent = &iomem_resource;
+
+	if (request_resource(parent, hose->mem_resource) < 0)
 		goto out;
 		goto out;
-	if (request_resource(&ioport_resource, hose->io_resource) < 0) {
+
+	parent = hose->io_resource->parent;
+	if (!parent)
+		parent = &ioport_resource;
+
+	if (request_resource(parent, hose->io_resource) < 0) {
 		release_resource(hose->mem_resource);
 		release_resource(hose->mem_resource);
 		goto out;
 		goto out;
 	}
 	}